Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15664#discussion_r94095175 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -568,10 +617,9 @@ object JdbcUtils extends Logging { conn.setAutoCommit(false) // Everything in the same db transaction. conn.setTransactionIsolation(finalIsolationLevel) } - val stmt = insertStatement(conn, table, rddSchema, dialect) - val setters: Array[JDBCValueSetter] = rddSchema.fields.map(_.dataType) - .map(makeSetter(conn, dialect, _)).toArray - val numFields = rddSchema.fields.length + val stmt = insertStatement(conn, table, schema, dialect) --- End diff -- We need to think about what is a better API interface of `savePartition`. Let me submit another commit and show you my rough idea.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org