Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16428
BTW, the reason I asked that in
https://github.com/apache/spark/pull/16428#issuecomment-269635303 is I remember
that I checked the reading/writing paths related with encodings before and the
encoding should be set to line record reader.
I just now double-chekced that newlines were `\n` for each batch due to
[`TextOutputFormat`s record
writer](https://github.com/apache/hadoop/blob/f67237cbe7bc48a1b9088e990800b37529f1db2a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/TextOutputFormat.java#L48-L49)
but it seems it was changed in [the recent
commit](https://github.com/apache/spark/pull/16089/files#diff-6a14f6bb643b1474139027d72a17f41aL203).
So, now, it seems the newlines are dependent on univocity library.
We should add some tests for this for sure, in `CSVSuite` to verify this
behaviour and prevent regressions.
As a small side note, we don't currently support non-ascii compatible
encodings in reading path if I haven't missed some changes in this path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
