Github user sethah commented on the issue:
https://github.com/apache/spark/pull/16457
I tend to think the actual algorithms should handle invalid weights,
instead of adding that check into instance creation. Also, this will add
overhead each time an instance is created.
Unless this solves some specific problem, I'm not sure I'm in favor of the
change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
