Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/16361
@cloud-fan, while I agree that the field names aren't really used here, I
don't think `patterns.scala` is the right place to fix this because it seems a
little dodgy to be picking a safe name way over there to fix an unsafe
interpolation over here. I'd be supportive of a change to set dummy names here
in the `*HashMapGenerator` classes or to make a builder for `StructType`s with
anonymous / safe field names, but that's a larger change that I think should be
done separately (it could also be accompanied by a change to remove the need to
pass in full `StructType`s when we only need the field count and types).
Given this, I'm going to retest and merge this as-is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
