GitHub user wangmiao1981 opened a pull request:
https://github.com/apache/spark/pull/16464
[SPARK-19066][SparkR]:SparkR LDA doesn't set optimizer correctly
## What changes were proposed in this pull request?
spark.lda passes the optimizer "em" or "online" as a string to the backend.
However, LDAWrapper doesn't set optimizer based on the value from R. Therefore,
for optimizer "em", the `isDistributed` field is FALSE, which should be TRUE
based on scala code.
In addition, the `summary` method should bring back the results related to
`DistributedLDAModel`.
## How was this patch tested?
Manual tests by comparing with scala example.
Modified the current unit test: fix the incorrect unit test and add
necessary tests for `summary` method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangmiao1981/spark new
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16464.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16464
----
commit 277763614934aef2625274e2e55e7efe6eb4c2df
Author: wm...@hotmail.com <wm...@hotmail.com>
Date: 2017-01-03T23:26:28Z
fix the optimizer bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
