Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1717#discussion_r17212834
--- Diff:
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
---
@@ -42,6 +44,7 @@ class TwitterInputDStream(
@transient ssc_ : StreamingContext,
twitterAuth: Option[Authorization],
filters: Seq[String],
+ locations: Seq[Seq[Double]],
--- End diff --
I should have caught and commented on this earlier, but why is this
`Seq[Seq[Double]]` and not of `Seq[(Double, Double)]` ? Its not like that the
location will ever be a sequence of more two doubles. So having a Seq[Double]
for latitude and longitude is pretty confusing. In fact having (Double, Double)
is still confusing, as it is not obvious which one is latitude and which one is
longitude. Hence, i think that its best to define a `case class
Location(latitude: Double, longitude: Double)` (within the
`org.apache.spark.streaming.twitter` package), and use that. This should be
most intuitive and least ambiguous.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
