Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16480#discussion_r94862191
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala ---
@@ -85,9 +86,27 @@ private[spark] class Instrumentation[E <: Estimator[_]]
private (
}
/**
+ * Log params for tuning estimators that search for the best params by
wrapping another
+ * estimator and using metrics computed by an evaluator.
+ *
+ * @param estimator the inner estimator called by the tuning estimator
+ * @param estimatorParamMaps different params tried by the tuning
estimator
+ * @param evaluator evaluator used to compute the metric for each
estimator param value
+ */
+ def logTuningParams(
--- End diff --
I like that this is separated out for all tuning algorithms, but it belongs
in ml.tuning. How about as a static (object) method in ValidatorParams?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
