Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16434#discussion_r94867603
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/ChiSqSelectorSuite.scala ---
@@ -35,22 +35,63 @@ class ChiSqSelectorSuite extends SparkFunSuite with
MLlibTestSparkContext
// Toy dataset, including the top feature for a chi-squared test.
// These data are chosen such that each feature's test has a distinct
p-value.
- /* To verify the results with R, run:
- library(stats)
- x1 <- c(8.0, 0.0, 0.0, 7.0, 8.0)
- x2 <- c(7.0, 9.0, 9.0, 9.0, 7.0)
- x3 <- c(0.0, 6.0, 8.0, 5.0, 3.0)
- y <- c(0.0, 1.0, 1.0, 2.0, 2.0)
- chisq.test(x1,y)
- chisq.test(x2,y)
- chisq.test(x3,y)
+ /*
+ * Contingency tables
--- End diff --
It's kind of nice seeing these tables, but for validation, it's much easier
for users to check using R. Could you please include a section for verifying
the results with R, like there was before?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
