Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16480#discussion_r94872199 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala --- @@ -76,6 +77,18 @@ private[ml] trait ValidatorParams extends HasSeed with Params { } est.copy(firstEstimatorParamMap).transformSchema(schema) } + + /** + * Instrumentation logging for tuning params including the inner estimator and evaluator info. + * + * @param instrumentation instrumentation logger + */ + protected def logTuningParams(instrumentation: Instrumentation[_]): Unit = { + instrumentation.log(compact(render(map2jvalue(Map[String, JValue]( --- End diff -- I'd say just use instrumentation.logNamedValue for each of these, rather than handling JSON here.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org