Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16479#discussion_r94897200
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/OutputWriter.scala
---
@@ -47,19 +47,6 @@ abstract class OutputWriterFactory extends Serializable {
path: String,
dataSchema: StructType,
context: TaskAttemptContext): OutputWriter
-
- /**
- * Returns a new instance of [[OutputWriter]] that will write data to
the given path.
- * This method gets called by each task on executor to write
InternalRows to
- * format-specific files. Compared to the other `newInstance()`, this is
a newer API that
- * passes only the path that the writer must write to. The writer must
write to the exact path
- * and not modify it (do not add subdirectories, extensions, etc.). All
other
- * file-format-specific information needed to create the writer must be
passed
- * through the [[OutputWriterFactory]] implementation.
- */
- def newWriter(path: String): OutputWriter = {
- throw new UnsupportedOperationException("newInstance with just path
not supported")
- }
--- End diff --
The usage of this function was removed in
https://github.com/apache/spark/pull/15710/files
I think it is safe to remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
