Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16430#discussion_r94902048
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/estimation/EstimationUtils.scala
 ---
    @@ -0,0 +1,54 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.plans.logical.estimation
    +
    +import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeMap}
    +import org.apache.spark.sql.catalyst.plans.logical.{ColumnStat, 
LogicalPlan}
    +import org.apache.spark.sql.types.StringType
    +
    +
    +object EstimationUtils {
    +
    +  /** Check if each plan has rowCount in its statistics. */
    +  def rowCountsExist(plans: LogicalPlan*): Boolean =
    +    plans.forall(_.statistics.rowCount.isDefined)
    +
    +  /** Get column stats for output attributes. */
    +  def getOutputMap(inputMap: AttributeMap[ColumnStat], output: 
Seq[Attribute])
    +    : AttributeMap[ColumnStat] = {
    +    AttributeMap(output.flatMap(a => inputMap.get(a).map(a -> _)))
    +  }
    +
    +  def getRowSize(attributes: Seq[Attribute], attrStats: 
AttributeMap[ColumnStat]): Long = {
    +    // We assign a generic overhead for a Row object, the actual overhead 
is different for different
    +    // Row format.
    +    8 + attributes.map { attr =>
    --- End diff --
    
    so rather than estimating like this, can we get the data size of the child 
node, and use that to estimate the data size of the parent?
    
    for fixed length types, we know the size; for variable length types, we 
assume the size is evenly distributed.
    
    e.g. if the total length is 1000, and we have rowcount 10, and we have 3 
fields: a int, b long, c string
    
    then we assume the avg length per row is 100, and the avg length of c would 
be 100 - 4 - 8 = 88?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to