Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16441
It looks like I am failing the binary compatibility tests despite this
constructor being private:
class GBTClassificationModel private[ml](
@Since("1.6.0") override val uid: String,
private val _trees: Array[DecisionTreeRegressionModel],
private val _treeWeights: Array[Double],
@Since("1.6.0") override val numFeatures: Int,
@Since("2.2.0") override val numClasses: Int)
extends ProbabilisticClassificationModel[Vector, GBTClassificationModel]
This is the same thing that happened in my original PR and then I had to
add the additional this() overload to pass the tests. In the PR comment it was
mentioned that I should be able to remove the unused constructor, does this
mean that I need to change the binary compatibility test somehow as well? My
guess is that the binary compat tests are java based and not scala based, in
which case private[ml] doesn't matter, so the solution would be to keep the
extra constructor I had before, just make sure that it is still private[ml],
only so I can pass the binary compat tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
