Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16464#discussion_r94983934
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LDAWrapper.scala ---
@@ -123,6 +126,10 @@ private[r] object LDAWrapper extends
MLReadable[LDAWrapper] {
.setMaxIter(maxIter)
.setSubsamplingRate(subsamplingRate)
+ if (optimizer == "em") {
--- End diff --
If it is "online", it is not necessary to set the optimizer. But setting it
anyway will make the code clean. I will do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
