Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16487#discussion_r95061397
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala 
---
    @@ -1289,4 +1290,66 @@ class HiveDDLSuite
           }
         }
       }
    +
    +  test("create hive serde table with Catalog") {
    +    withTable("t") {
    +      withTempDir { dir =>
    +        val df = spark.catalog.createExternalTable(
    +          "t",
    +          "hive",
    +          new StructType().add("i", "int"),
    +          Map("path" -> dir.getCanonicalPath, "fileFormat" -> "parquet"))
    --- End diff --
    
    in the design decision, we want to hide the managed/external concept from 
users. I not sure if we want to rename this API...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to