Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95063071
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewBackwardCompatibilitySuite.scala
---
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.execution
+
+import org.apache.spark.sql.QueryTest
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.catalyst.catalog.{CatalogStorageFormat,
CatalogTable, CatalogTableType}
+import org.apache.spark.sql.hive.test.TestHiveSingleton
+import org.apache.spark.sql.test.SQLTestUtils
+import org.apache.spark.sql.types.StructType
+
+/**
+ * A suite for testing resolve the views defined by older versions of
Spark(before 2.2)
+ */
+class SQLViewBackwardCompatibilitySuite extends QueryTest
+ with SQLTestUtils with TestHiveSingleton {
+
+ private val DATABASE_NAME = "test_db"
+
+ override def beforeAll(): Unit = {
+ sql(s"CREATE DATABASE $DATABASE_NAME")
+ for ((tbl, _) <- rawTablesAndExpectations) {
+ spark.sessionState.catalog.createTable(tbl, ignoreIfExists = false)
+ }
+ }
+
+ override def afterAll(): Unit = {
+ sql(s"DROP DATABASE IF EXISTS $DATABASE_NAME CASCADE")
+ }
+
+ private val simpleSchema = new StructType().add("id", "int").add("id1",
"int")
+
+ lazy val jsonTable = CatalogTable(
+ identifier = TableIdentifier("json_table", Some(DATABASE_NAME)),
+ tableType = CatalogTableType.MANAGED,
+ provider = Some("json"),
+ storage = CatalogStorageFormat.empty,
+ schema = simpleSchema)
+
+ lazy val parquetTable = CatalogTable(
+ identifier = TableIdentifier("parquet_table", Some(DATABASE_NAME)),
+ tableType = CatalogTableType.MANAGED,
+ provider = Some("parquet"),
+ storage = CatalogStorageFormat.empty,
+ schema = simpleSchema,
+ partitionColumnNames = Seq("id"))
+
+ lazy val hiveParquetTable = CatalogTable(
+ identifier = TableIdentifier("hive_parquet_table",
Some(DATABASE_NAME)),
+ tableType = CatalogTableType.MANAGED,
+ provider = Some("hive"),
+ storage = CatalogStorageFormat.empty.copy(
+ inputFormat =
Some("org.apache.hadoop.hive.ql.io.parquet.MapredParquetInputFormat"),
+ outputFormat =
Some("org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat"),
+ serde =
Some("org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe")),
+ schema = simpleSchema)
+
+ lazy val hiveOrcTable = CatalogTable(
+ identifier = TableIdentifier("hive_orc_table", Some(DATABASE_NAME)),
+ tableType = CatalogTableType.MANAGED,
+ provider = Some("hive"),
+ storage = CatalogStorageFormat.empty.copy(
+ inputFormat =
Some("org.apache.hadoop.hive.ql.io.orc.OrcInputFormat"),
+ outputFormat =
Some("org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat"),
+ serde = Some("org.apache.hadoop.hive.ql.io.orc.OrcSerde")),
+ schema = simpleSchema)
+
+ // A list of all raw tables we want to test, with their expected schema.
+ lazy val rawTablesAndExpectations = Seq(
--- End diff --
Why do we need to check different source tables?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
