Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15413#discussion_r95064130
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/GaussianMixtureSuite.scala
---
@@ -126,9 +143,93 @@ class GaussianMixtureSuite extends SparkFunSuite with
MLlibTestSparkContext
testEstimatorAndModelReadWrite(gm, dataset,
GaussianMixtureSuite.allParamSettings, checkModelData)
}
+
--- End diff --
In most of the other test suites in ML we have a test that checks the
prediction/transform methods. For example, checking that the prediction always
matches the highest probability, checking that probabilities sum to one. I
don't see much reason to diverge from that pattern here, what do you think
@yanboliang?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
