Github user mallman commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16499#discussion_r95066296
  
    --- Diff: 
core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala 
---
    @@ -387,12 +388,23 @@ class BlockManagerReplicationSuite extends 
SparkFunSuite
             testStore => 
blockLocations.contains(testStore.blockManagerId.executorId)
           }.foreach { testStore =>
             val testStoreName = testStore.blockManagerId.executorId
    -        assert(
    -          testStore.getLocalValues(blockId).isDefined, s"$blockId was not 
found in $testStoreName")
    -        testStore.releaseLock(blockId)
    --- End diff --
    
    N.B. We no longer need the `releaseLock` call because we exhaust the 
iterator returned by `getLocalValues`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to