Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16504#discussion_r95092473
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -730,8 +730,9 @@ def join(self, other, on=None, how=None):
a join expression (Column), or a list of Columns.
If `on` is a string or a list of strings indicating the name
of the join column(s),
the column(s) must exist on both sides, and this performs an
equi-join.
- :param how: str, default 'inner'.
- One of `inner`, `outer`, `left_outer`, `right_outer`,
`leftsemi`.
+ :param how: str, default ``inner``. Must be any of: ``inner``,
``cross``, ``outer``,
--- End diff --
perhaps `Must be one of` is more concise and consistent?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
