Github user neggert commented on the issue:
https://github.com/apache/spark/pull/15018
Your changes sound fine. I don't have strong feelings one way or another,
although I think we should at least throw a warning if we're discarding points.
I do want to point out that disallowing negative weights also breaks the API,
since they were previously supported (there's even a test for them).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
