Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16522#discussion_r95281803 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala --- @@ -94,7 +94,13 @@ private[sql] trait SQLTestUtils */ protected def withSQLConf(pairs: (String, String)*)(f: => Unit): Unit = { val (keys, values) = pairs.unzip - val currentValues = keys.map(key => Try(spark.conf.get(key)).toOption) + val currentValues = keys.map { key => + if (spark.conf.contains(key)) { + Try(spark.conf.get(key)).toOption --- End diff -- Nit: you can just use `Some(spark.conf.get(key))`. It's better to not hide exceptions from `get`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org