Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/15505#discussion_r95304052
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -149,7 +149,12 @@ private[spark] object Utils extends Logging {
/** Deserialize an object using Java serialization and the given
ClassLoader */
def deserialize[T](bytes: Array[Byte], loader: ClassLoader): T = {
- val bis = new ByteArrayInputStream(bytes)
+ deserialize(ByteBuffer.wrap(bytes), loader)
+ }
+
+ /** Deserialize an object using Java serialization and the given
ClassLoader */
+ def deserialize[T](bytes: ByteBuffer, loader: ClassLoader): T = {
+ val bis = new ByteBufferInputStream(bytes)
--- End diff --
I don't think there's a problem here. it is covered by many test cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
