Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16233#discussion_r95305370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -174,6 +176,7 @@ case class CatalogTable(
stats: Option[CatalogStatistics] = None,
viewOriginalText: Option[String] = None,
viewText: Option[String] = None,
+ viewDefaultDatabase: Option[String] = None,
--- End diff --
can we make this a table property instead of a field? something like
```
case class CatalogTable(...) {
def viewDefaultDatabase: Opion[String] =
properties.get(VIEW_DEFAULT_DATABASE)
}
object CatalogTable {
val VIEW_DEFAULT_DATABASE = "view.default.database"
}
```
This is only used in a few places and I don't think it worth to add so many
hacks in `HiveExternalCatalog`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
