Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/1360#discussion_r17255027
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
---
@@ -234,7 +234,7 @@ private[spark] class Worker(
try {
logInfo("Asked to launch executor %s/%d for %s".format(appId,
execId, appDesc.name))
val manager = new ExecutorRunner(appId, execId, appDesc, cores_,
memory_,
- self, workerId, host, sparkHome, workDir, akkaUrl, conf,
ExecutorState.RUNNING)
+ self, workerId, host, sparkHome, workDir, akkaUrl, conf,
ExecutorState.LOADING)
--- End diff --
It's part of the fix. ExecutorRunners now start in state LOADING and don't
become RUNNING until their process is running and stderr && stdout are
successfully opened -- see the changes in this PR to ExecutorRunner.scala. If
ExecutorRunners were to continue to be created in state RUNNING, then new check
for RUNNING Executors in Master.scala will always prevent Applications from
being killed even though useful Executors doing actual work may not exist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
