Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16547#discussion_r95571124
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala
---
@@ -132,13 +132,13 @@ class EventTimeWatermarkSuite extends StreamTest with
BeforeAndAfter with Loggin
CheckLastBatch(),
AddData(inputData, 25), // Advance watermark to 15 seconds
CheckLastBatch(),
- assertNumStateRows(3),
+ assertNumStateRows(3, 1),
AddData(inputData, 25), // Emit items less than watermark and drop
their state
CheckLastBatch((10, 5)),
- assertNumStateRows(2),
+ assertNumStateRows(2, 1),
AddData(inputData, 10), // Should not emit anything as data less
than watermark
CheckLastBatch(),
- assertNumStateRows(2)
+ assertNumStateRows(2, 1) // We also processed the data 10, which is
less than watermark
--- End diff --
note this is `assertNumStateRows(2, 1)` without this patch, and is
`assertNumStateRows(2, 0)` with this patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
