Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16549#discussion_r95589320
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -383,14 +383,25 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
// Get all input data source relations of the query.
val srcRelations = df.logicalPlan.collect {
case LogicalRelation(src: BaseRelation, _, _) => src
+ case relation: CatalogRelation if
DDLUtils.isHiveTable(relation.catalogTable) => relation
}
+
EliminateSubqueryAliases(catalog.lookupRelation(tableIdentWithDB))
match {
// Only do the check if the table is a data source table (the
relation is a BaseRelation).
- // TODO(cloud-fan): also check hive table relation here when we
support overwrite mode
// for creating hive tables.
case LogicalRelation(dest: BaseRelation, _, _) if
srcRelations.contains(dest) =>
throw new AnalysisException(
s"Cannot overwrite table $tableName that is also being read
from")
+ // check hive table relation when overwrite mode
+ case relation: CatalogRelation if
DDLUtils.isHiveTable(relation.catalogTable)
+ && srcRelations.filter(_.isInstanceOf[CatalogRelation]).exists
{
--- End diff --
doesn't `srcRelations.contains(dest)` work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
