Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16503#discussion_r95660339
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -165,9 +167,14 @@ private[spark] class OutputCommitCoordinator(conf:
SparkConf, isDriver: Boolean)
authorizedCommitters(partition) = attemptNumber
true
case existingCommitter =>
- logDebug(s"Denying attemptNumber=$attemptNumber to commit for
stage=$stage, " +
- s"partition=$partition; existingCommitter =
$existingCommitter")
- false
+ // Coordinator should be idempotent when receiving
AskPermissionToCommit.
+ if (existingCommitter == attemptNumber) {
+ true
--- End diff --
please log a warning here before returning `true` -- reaching this branch
is likely indicative of network problems
```
logWarning(s"Authorizing duplicate request to commit for " +
s"attemptNumber=$attemptNumber to commit for stage=$stage,
partition=$partition; " +
s"existingCommitter = $existingCommitter. This can indicate
dropped network traffic.")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
