Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16549#discussion_r95981274 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -383,14 +383,19 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) { // Get all input data source relations of the query. val srcRelations = df.logicalPlan.collect { case LogicalRelation(src: BaseRelation, _, _) => src + case relation: CatalogRelation if DDLUtils.isHiveTable(relation.catalogTable) => relation --- End diff -- how about we only collect table identifiers? ``` val srcTables = df.logicalPlan.collect { case relation: CatalogRelation if DDLUtils.isHiveTable(relation.catalogTable) => relation.catalogTable.identifier } ... case relation: CatalogRelation if DDLUtils.isHiveTable(relation.catalogTable) && srcTables.contains(relation.catalogTable.identidier) => throw ... ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org