Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16516
yep, I wrote that in a comment above, I totally agree:
1.) we are specifying some column name as a parameter
2.) RModel formula (from RFormula.scala)
3.) Tokenizer.scala regex pattern
for AUC I don't think it should matter though, but it's not too significant.
I still think for the check we should have one method instead of
duplicating code, and same for accessing the value (instead of calling .toLower
everywhere in the transform's/estimator's code).
I believe anywhere where there is duplicate code there is room for
refactoring. Otherwise, the changes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
