Github user li-zhihui commented on a diff in the pull request:
https://github.com/apache/spark/pull/1616#discussion_r17278282
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -313,14 +313,74 @@ private[spark] object Utils extends Logging {
}
/**
+ * Download a file requested by the executor . Supports fetching the
file in a variety of ways,
+ * including HTTP, HDFS and files on a standard filesystem, based on the
URL parameter.
+ *
+ * If `useCache` is true, first attempts to fetch the file from a local
cache that's shared across
+ * executors running the same application.
+ *
+ * Throws SparkException if the target file already exists and has
different contents than
+ * the requested file.
+ */
+ def fetchFile(
+ url: String,
+ targetDir: File,
+ conf: SparkConf,
+ securityMgr: SecurityManager,
+ hadoopConf: Configuration,
+ timestamp: Long,
+ useCache: Boolean) {
+ val fileName = url.split("/").last
+ val targetFile = new File(targetDir, fileName)
+ if (useCache) {
+ val cachedFileName = url.hashCode + timestamp + "_cach"
+ val lockFileName = url.hashCode + timestamp + "_lock"
+ val localDir = new File(getLocalDir(conf))
+ val lockFile = new File(localDir, lockFileName)
+ val raf = new RandomAccessFile(lockFile, "rw")
+ // Only one executor entry.
+ // The FileLock is only used to control synchronization for
executors download file,
+ // it's always safe regardless of lock type(mandatory or advisory).
+ val lock = raf.getChannel().lock()
+ val cachedFile = new File(localDir, cachedFileName)
+ try {
+ if (!cachedFile.exists()) {
+ doFetchFile(url, localDir, conf, securityMgr, hadoopConf)
+ Files.move(new File(localDir, fileName), cachedFile)
+ }
+ } finally {
+ lock.release()
+ }
+ Files.copy(cachedFile, targetFile)
--- End diff --
I think it's OK, but now executor use these files as they are in their work
directory <code>./</code>. Maybe we can optimize to avoid the copy in next
patch if we prove this patch work well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
