Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16517#discussion_r96130318 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala --- @@ -86,6 +86,42 @@ class DetermineHiveSerde(conf: SQLConf) extends Rule[LogicalPlan] { } } +class HiveAnalysis(session: SparkSession) extends Rule[LogicalPlan] { + override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators { + case InsertIntoTable(table: MetastoreRelation, partSpec, query, overwrite, ifNotExists) + if hasBeenPreprocessed(table.output, table.partitionKeys.toStructType, partSpec, query) => + InsertIntoHiveTable(table, partSpec, query, overwrite, ifNotExists) + + case CreateTable(tableDesc, mode, Some(query)) if DDLUtils.isHiveTable(tableDesc) => + // Currently we will never hit this branch, as SQL string API can only use `Ignore` or + // `ErrorIfExists` mode, and `DataFrameWriter.saveAsTable` doesn't support hive serde + // tables yet. + if (mode == SaveMode.Append || mode == SaveMode.Overwrite) { + throw new AnalysisException( + "CTAS for hive serde tables does not support append or overwrite semantics.") + } --- End diff -- The above codes need to merge from the latest master build.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org