Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16561#discussion_r96157384 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -198,9 +203,44 @@ case class CatalogTable( /** * Return the default database name we use to resolve a view, should be None if the CatalogTable - * is not a View. + * is not a View or created by older versions of Spark(before 2.2.0). + */ + def viewDefaultDatabase: Option[String] = properties.get(VIEW_DEFAULT_DATABASE) + + /** + * Return the output column names of the query that creates a view, the column names are used to + * resolve a view, should be None if the CatalogTable is not a View or created by older versions + * of Spark(before 2.2.0). + */ + def viewQueryColumnNames: Seq[String] = { + for { + numCols <- properties.get(VIEW_QUERY_OUTPUT_COLUMN_NUM).toSeq + index <- 0 until numCols.toInt + } yield properties.getOrElse( + s"$VIEW_QUERY_OUTPUT_COLUMN_NAME_PREFIX$index", + throw new AnalysisException("Corrupted view query output column names in catalog: " + + s"$numCols parts expected, but part $index is missing.") + ) + } + + /** + * Insert/Update the view query output column names in `properties`. */ - def viewDefaultDatabase: Option[String] = properties.get(CatalogTable.VIEW_DEFAULT_DATABASE) + def withQueryColumnNames(columns: Seq[String]): CatalogTable = { + val props = new mutable.HashMap[String, String] --- End diff -- let's follow the existing code for partition columns ``` properties.put(DATASOURCE_SCHEMA_NUMPARTCOLS, partitionColumns.length.toString) partitionColumns.zipWithIndex.foreach { case (partCol, index) => properties.put(s"$DATASOURCE_SCHEMA_PARTCOL_PREFIX$index", partCol) } ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org