Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16474#discussion_r96162528
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
---
@@ -135,11 +135,21 @@ class FileScanRDD(
try {
if (ignoreCorruptFiles) {
currentIterator = new NextIterator[Object] {
- private val internalIter = readFunction(currentFile)
+ private val internalIter = {
+ try {
+ // The readFunction may read files before consuming
the iterator.
+ // E.g., vectorized Parquet reader.
+ readFunction(currentFile)
--- End diff --
I think it is hard to guarantee this because `readFunction` is coming from
individual data source. Even we can modify current data sources, we may not be
able to prevent other data sources doing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
