GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/16592
[SPARK-19235] [SQL] [TESTS] Enable Test Cases in DDLSuite with Hive
Metastore
### What changes were proposed in this pull request?
So far, the test cases in DDLSuites only verify the behaviors of
InMemoryCatalog. That means, they do not cover the scenarios using
HiveExternalCatalog. Thus, we need to improve the existing test suite to run
these cases using Hive metastore.
When porting these test cases, a bug of `SET LOCATION` is found. `path` is
not set when the location is not changed.
After this PR, a few changes are made, as summarized below,
- `DDLSuite` becomes an abstract class. Both `InMemoryCatalogedDDLSuite`
and `HiveCatalogedDDLSuite` extend it. `InMemoryCatalogedDDLSuite` is using
`InMemoryCatalog`. `HiveCatalogedDDLSuite` is using `HiveExternalCatalog`.
- `InMemoryCatalogedDDLSuite` contains all the existing test cases in
`DDLSuite`.
- `HiveCatalogedDDLSuite` contains a subset of `DDLSuite`. The following
test cases are excluded:
1. The following test cases only make sense for `InMemoryCatalog`:
```
test("desc table for parquet data source table using in-memory catalog")
test("select/insert into the managed table")
test("select/insert into external table")
test("Create Hive Table As Select")
```
2. The following test cases are unable to be ported because we are unable
to alter table provider when using Hive metastore. In the future PRs we need to
improve the test cases so that altering table provider is not needed:
```
test("alter table: set location (datasource table)")
test("alter table: set properties (datasource table)")
test("alter table: unset properties (datasource table)")
test("alter table: set serde (datasource table)")
test("alter table: set serde partition (datasource table)")
test("alter table: change column (datasource table)")
test("alter table: add partition (datasource table)")
test("alter table: drop partition (datasource table)")
test("alter table: rename partition (datasource table)")
test("drop table - data source table")
```
**TODO** : in the future PRs, we need to remove `HiveDDLSuite` and move the
test cases to either `DDLSuite`, `InMemoryCatalogedDDLSuite` or
`HiveCatalogedDDLSuite`.
### How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark refactorDDLSuite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16592.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16592
----
commit 01334635c5433f0515beb92660b79796c97677d5
Author: gatorsmile <gatorsm...@gmail.com>
Date: 2017-01-16T04:52:55Z
fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
