Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r96178803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -195,19 +231,26 @@ case class Hour(child: Expression) extends
UnaryExpression with ImplicitCastInpu
> SELECT _FUNC_('2009-07-30 12:58:59');
58
""")
-case class Minute(child: Expression) extends UnaryExpression with
ImplicitCastInputTypes {
+case class Minute(child: Expression, timeZoneId: Option[String] = None)
--- End diff --
No, `Minute` / `Second` should also be timezone-aware because `TimeZone`
can have millisecond offset. Actually, there are some timezones which have
offset of some hours and 30 minutes. There is no timezone which has non-zero
second offset for now, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
