Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96275903
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -300,7 +311,7 @@ abstract class ExplodeBase extends UnaryExpression with
CollectionGenerator with
case class Explode(child: Expression) extends ExplodeBase {
override val position: Boolean = false
}
-
+class OuterExplode(child: Expression) extends
GeneratorOuter(Explode(child))
--- End diff --
Remove this. Favor composition over inheritance. Just create a
`GeneratorOuter(Explode(child))` whenever you need this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
