Github user bogdanrdc commented on a diff in the pull request:
https://github.com/apache/spark/pull/16608#discussion_r96322905
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -300,7 +311,7 @@ abstract class ExplodeBase extends UnaryExpression with
CollectionGenerator with
case class Explode(child: Expression) extends ExplodeBase {
override val position: Boolean = false
}
-
+class OuterExplode(child: Expression) extends
GeneratorOuter(Explode(child))
--- End diff --
Reverted to GeneratorOuter(Explode()) and created a new helper method in
FunctionRegistry instead.
Actually the way I made these classes wasn't working. It was returning
strange results, but not failing otherwise. I guess somewhere the OuterExplode
class was not caught by a match. The generated code was different.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
