Github user djvulee commented on a diff in the pull request:
https://github.com/apache/spark/pull/16599#discussion_r96357233
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -431,6 +432,8 @@ def jdbc(self, url, table, column=None,
lowerBound=None, upperBound=None, numPar
if column is not None:
if numPartitions is None:
numPartitions = self._spark._sc.defaultParallelism
--- End diff --
I have a little worry whether this change will break the API. If some users
just specify the `column`, `lowerBound`, `upperBound` in some Spark version,
its program will fail after update, even very few people just use the default
parallelism.
In my personal opinion, I prefer to make a change and keep API consistent.
If your opinion is to add the assert on `numPartitions`, I will update the
PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
