Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16613#discussion_r96580275
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -207,29 +210,35 @@ case class CreateViewCommand(
}
/**
- * Returns a [[CatalogTable]] that can be used to save in the catalog.
This comment canonicalize
- * SQL based on the analyzed plan, and also creates the proper schema
for the view.
+ * Returns a [[CatalogTable]] that can be used to save in the catalog.
Generate the view-specific
+ * properties(e.g. view default database, view query output column
names) and store them as
+ * properties in the CatalogTable, and also creates the proper schema
for the view.
+ *
+ * @param session the spark session.
+ * @param aliasedPlan if `userSpecifiedColumns` is defined, the aliased
plan outputs the user
+ * specified columns, else it is the same as the
`analyzedPlan`.
+ * @param analyzedPlan the analyzed logical plan that represents the
child of a view.
--- End diff --
why we need both `aliasedPlan` and `analyzedPlan`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
