Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16441#discussion_r96708082 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/loss/Loss.scala --- @@ -67,3 +66,12 @@ trait Loss extends Serializable { */ private[spark] def computeError(prediction: Double, label: Double): Double } + +private[spark] trait ClassificationLoss extends Loss { + /** + * Computes the class probability given the margin. + * @param prediction The margin. + * @return The class probability from the margin. + */ + private[spark] def computeProbability(prediction: Double): Double --- End diff -- Rename prediction -> margin. Then you don't even need to document the param.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org