GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/16639
[SPARK-19276][CORE] Fetch Failure handling robust to user error handling
## What changes were proposed in this pull request?
Fault-tolerance in spark requires special handling of shuffle fetch
failures. The Executor would catch FetchFailedException and send a
special msg back to the driver.
However, intervening user code could intercept that exception, and wrap
it with something else. This even happens in SparkSQL. So rather than
checking the exception directly, we'll store the fetch failure directly
in the TaskContext, where users can't touch it.
## How was this patch tested?
Added a test case which failed before the fix. Full test suite via jenkins.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/squito/spark SPARK-19276
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16639.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16639
----
commit 0091abacb930642a4ef2178a31be7d6b70462766
Author: Imran Rashid <iras...@cloudera.com>
Date: 2017-01-18T21:55:50Z
[SPARK-19276][CORE] Fetch Failure handling robust to user error handling
Fault-tolerance in spark requires special handling of shuffle fetch
failures. The Executor would catch FetchFailedException and send a
special msg back to the driver.
However, intervening user code could intercept that exception, and wrap
it with something else. This even happens in SparkSQL. So rather than
checking the exception directly, we'll store the fetch failure directly
in the TaskContext, where users can't touch it.
This includes a test case which failed before the fix.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
