Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16592#discussion_r97030540
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -115,6 +281,16 @@ class DDLSuite extends QueryTest with SharedSQLContext
with BeforeAndAfterEach {
catalog.createPartitions(tableName, Seq(part), ignoreIfExists = false)
}
+ private def getDatabaseLocation(dbName: String): String = {
+ val expectedLocation = if (isUsingHiveMetastore) {
+ val dbPath = new Path(spark.sessionState.conf.warehousePath)
+ s"${dbPath.toUri.getPath.stripSuffix("/")}/$dbName.db"
+ } else {
+ s"spark-warehouse/$dbName.db"
--- End diff --
why hardcode it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
