Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/2332#issuecomment-55054562
@chouqin Thanks for your responses. I think you've convinced me that
Predict is reasonable, since it is a different concept from info gain. Could
you please make it private[tree] though?
Clarification for 1.: By "array of bins," do you mean the array of classes
to calculate the prediction (for classification)? Unless there are a very
large number of classes, I do not think the savings will be that much.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
