Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16626#discussion_r97195490
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -584,14 +593,18 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
// Sets the `schema`, `partitionColumnNames` and `bucketSpec` from
the old table definition,
// to retain the spark specific format if it is. Also add old data
source properties to table
// properties, to retain the data source table format.
- val oldDataSourceProps =
oldTableDef.properties.filter(_._1.startsWith(DATASOURCE_PREFIX))
--- End diff --
Hmm, I think this branch is for datasource table, but looks like you don't
support datasource table yet in this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
