Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16245#discussion_r97211599
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -514,6 +514,34 @@ case class OptimizeCodegen(conf: CatalystConf) extends
Rule[LogicalPlan] {
/**
+ * Reorders the predicates in `Filter` so more expensive expressions like
UDF can evaluate later.
+ */
+object ReorderPredicatesInFilter extends Rule[LogicalPlan] with
PredicateHelper {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case f @ Filter(pred, child) =>
+ // Extracts deterministic suffix expressions from Filter predicate.
+ val expressions = splitConjunctivePredicates(pred)
+ // The beginning index of the deterministic suffix expressions.
+ var splitIndex = -1
+ (expressions.length - 1 to 0 by -1).foreach { idx =>
+ if (splitIndex == -1 && !expressions(idx).deterministic) {
+ splitIndex = idx + 1
+ }
+ }
+ if (splitIndex == expressions.length) {
+ // All expressions are non-deterministic, no reordering.
+ f
+ } else {
+ val (nonDeterminstics, deterministicExprs) =
expressions.splitAt(splitIndex)
--- End diff --
yes. however, if the first expression in the `AND` is `non-deterministic`,
skipping it might change its next evaluation. so we can only reorder the
deterministic expressions after non-deterministic expressions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
