Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16308#discussion_r97346228
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -475,6 +1164,45 @@ class DateFunctionsSuite extends QueryTest with
SharedSQLContext {
Row(ts1.getTime / 1000L), Row(ts2.getTime / 1000L)))
}
+ test("to_unix_timestamp with session local timezone") {
--- End diff --
These newly added tests are so similar that they all try to prove one
thing: when you convert string or date to timestamp, the result changes
according to session local timezone. When you convert timestamp to string or
date, the result also changes with session local timezone. All time-related
expressions should respect this.
shall we just write a general test for this? then we don't need so many
similar tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
