Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16660#discussion_r97347604
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
    @@ -71,7 +73,104 @@ object UDT {
     
     }
     
    +// object and classes to test SPARK-19311
    +
    +// Trait/Interface for base type
    +@SQLUserDefinedType(udt = classOf[ExampleBaseTypeUDT])
    +sealed trait IExampleBaseType extends Serializable {
    +  def field: Int
    +}
    +
    +// Trait/Interface for derived type
    +@SQLUserDefinedType(udt = classOf[ExampleSubTypeUDT])
    +sealed trait IExampleSubType extends IExampleBaseType
    +
    +// a base class
    +class ExampleBaseClass(override val field: Int) extends IExampleBaseType {
    +  override def toString: String = field.toString
    --- End diff --
    
    why override `toString` here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to