Github user imatiach-msft commented on the issue:

    https://github.com/apache/spark/pull/16699
  
    can you please:
    1.) add [MLLIB] to the title
    2.) fix the MiMa tests
    The MiMa tests error seems to be related to the interface change, probably 
you need to add an exclude to the file "project/MimaExcludes.scala":
    
    [error]  * abstract method getOffsetCol()java.lang.String in trait 
org.apache.spark.ml.param.shared.HasOffsetCol is inherited by class 
GeneralizedLinearRegressionBase in current version.
    [error]    filter with: 
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasOffsetCol.getOffsetCol")
    [error]  * abstract method offsetCol()org.apache.spark.ml.param.Param in 
trait org.apache.spark.ml.param.shared.HasOffsetCol is inherited by class 
GeneralizedLinearRegressionBase in current version.
    [error]    filter with: 
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("org.apache.spark.ml.param.shared.HasOffsetCol.offsetCol")
    [error]  * abstract synthetic method 
org$apache$spark$ml$param$shared$HasOffsetCol$_setter_$offsetCol_=(org.apache.spark.ml.param.Param)Unit
 in trait org.apache.spark.ml.param.shared.HasOffsetCol is inherited by class 
GeneralizedLinearRegressionBase in current version.
    [error]    filter with: 
ProblemFilters.exclude[InheritedNewAbstractMethodProblem]("
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to