Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16699
@imatiach-msft Thanks so much for your detailed review. Incredibly helpful.
I've addressed all your comments in the new commit. Major changes are
highlighted below:
1. Create `OffsetInstance` in Instance.scala and remove dependency of IWLS
on regression.
2. Add param checking for offset.
Let me know if there is anything else that needs improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
