Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97933132
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala
---
@@ -48,6 +77,14 @@ class StatsConfSuite extends StatsEstimationTestBase {
// Return the simple statistics
assert(plan.stats(conf.copy(cboEnabled = false)) ==
expectedDefaultStats)
}
+
+ /** Check estimated stats which is the same when cbo is turned on/off. */
+ private def checkStats(plan: LogicalPlan, expected: Statistics): Unit = {
--- End diff --
You know, this is a utility function. We can make it more general by having
two expected stats values
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
