Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16707#discussion_r97937744
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -125,7 +125,7 @@ class UDFRegistration private[sql] (functionRegistry:
FunctionRegistry) extends
def register[RT: TypeTag](name: String, func: Function0[RT]):
UserDefinedFunction = {
val dataType = ScalaReflection.schemaFor[RT].dataType
val inputTypes = Try(Nil).toOption
- def builder(e: Seq[Expression]) = ScalaUDF(func, dataType, e,
inputTypes.getOrElse(Nil))
+ def builder(e: Seq[Expression]) = ScalaUDF(func, dataType, e,
inputTypes.getOrElse(Nil), Some(name))
--- End diff --
Oh, I remember I was told that we should remove or fix the comments above
to generate this codes too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
